Derived Telemetry Prototype #7815
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
| // Increment suffix after exhausting the alphabet | ||
| suffix = (parseInt(suffix, 10) || 0) + 1; |
There was a problem hiding this comment.
why wasn't this covered by tests?
There was a problem hiding this comment.
we'd need 26 different parameters before slapping numbers on them. e.g., a,b,..z,a1,b2,c2,etc.
| let valueToUse = rangeItems[0]?.key; | ||
| if (!valueToUse) { | ||
| // if no numeric data type, just use the first one | ||
| valueToUse = metaData.valueMetadatas[0]?.key; |
There was a problem hiding this comment.
SWGs have numeric data types, so we never fall through here.
unlikelyzero
added
the
notable_change
| <div :class="['c-comps__refs-controls c-cdef__controls', { disabled: !parameters?.length }]"> | ||
| <label v-if="isEditing" class="c-toggle-switch"> | ||
| <input type="checkbox" :checked="testDataApplied" @change="toggleTestData" /> | ||
| <span class="c-toggle-switch__slider" aria-label="Apply Test Data"></span> |
There was a problem hiding this comment.
this might not be necessary. You may be able to just use the vanilla label and modify your test to be:
page.getByRole('checkbox', { name : Apply Test Data }There was a problem hiding this comment.
tried this, but unfortunately didn't work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Closes #7823
Add a new object called "Derived Telemetry" that allows telemetry to be used in simple mathematical expressions.
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist